Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tests-completed job fails if required jobs before it do #19948

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Ensure tests-completed job fails if required jobs before it do #19948

merged 1 commit into from
Apr 3, 2023

Conversation

kubawi
Copy link
Contributor

@kubawi kubawi commented Apr 3, 2023

No description provided.

@kubawi kubawi requested a review from a team as a code owner April 3, 2023 15:09
@kubawi kubawi requested a review from marcboudreau April 3, 2023 15:12
marcboudreau
marcboudreau suggested changes Apr 3, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kubawi
Ensure tests-completed job fails if required jobs either fail or are …
a2904a5 
…cancelled

Otherwise, the tests-completed job should succeed, including when the test-ui
job is skipped.
@marcboudreau marcboudreau force-pushed the kubawi-make-tests-completed-fail-if-required-checks-fail branch from 352d218 to a2904a5 Compare April 3, 2023 18:33
@marcboudreau marcboudreau merged commit de381c3 into main Apr 3, 2023
This was referenced Apr 3, 2023
Merged
Merged
Merged
@kubawi kubawi deleted the kubawi-make-tests-completed-fail-if-required-checks-fail branch April 3, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcboudreau marcboudreau marcboudreau approved these changes

Assignees
No one assigned
Labels
pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubawi @marcboudreau